Hide non-native volumes when saving files from the browser.

Hide non-native volumes when saving files from the browser.

Chrome browser opens Files app as a file saving dialog.  The caller of saving
dialog has a special handling for drive paths, but it does not handle other
non-native paths (e.g. FSP, MTP)

The CL lets Files app know which types of paths are handled by caller and hide
volumes that are not supported by caller.

BUG=581984
TEST=Check with standalone Files app, save dialog, open dialog

Committed: https://crrev.com/e820f8581d44df14269df140fc71d70adde7262b
Cr-Commit-Position: refs/heads/master@{#376073}

[hirono, 2016-02-17 08:04:53]

hirono@chromium.org changed reviewers:
+ mtomasz@chromium.org

[hirono, 2016-02-17 08:04:53]

PTAL, thanks!

[mtomasz, 2016-02-17 08:20:49]

lgtm with two tiny nits!

https://codereview.chromium.org/1701163003/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js
(right):

https://codereview.chromium.org/1701163003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js:68: if
(this.allowedPaths_ == AllowedPaths.ANY_PATH)
nit: === here and in other places

https://codereview.chromium.org/1701163003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js:184: //
Filters drive related volumes.
tiny nit: drive -> Drive

[hirono, 2016-02-17 08:29:19]

Thanks!

https://codereview.chromium.org/1701163003/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js
(right):

https://codereview.chromium.org/1701163003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js:68: if
(this.allowedPaths_ == AllowedPaths.ANY_PATH)
On 2016/02/17 08:20:49, mtomasz wrote:
> nit: === here and in other places

Done.

https://codereview.chromium.org/1701163003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js:184: //
Filters drive related volumes.
On 2016/02/17 08:20:49, mtomasz wrote:
> tiny nit: drive -> Drive

Done.

[hirono, 2016-02-17 08:29:20]

Thanks!

[hirono, 2016-02-17 08:29:22]

The CQ bit was checked by hirono@chromium.org

[hirono, 2016-02-17 08:29:23]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/1701163003/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-02-17 08:29:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701163003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701163003/40001

[commit-bot: I haz the power, 2016-02-17 09:09:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 09:09:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hirono, 2016-02-18 02:09:53]

The CQ bit was checked by hirono@chromium.org

[hirono, 2016-02-18 02:09:53]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/1701163003/#ps60001
(title: "Fix tests")

[commit-bot: I haz the power, 2016-02-18 02:11:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701163003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701163003/60001

[commit-bot: I haz the power, 2016-02-18 02:40:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-18 02:41:04]

Description was changed from

==========
Hide non-native volumes when saving files from the browser.

Chrome browser opens Files app as a file saving dialog.  The caller of saving
dialog has a special handling for drive paths, but it does not handle other
non-native paths (e.g. FSP, MTP)

The CL lets Files app know which types of paths are handled by caller and hide
volumes that are not supported by caller.

BUG=581984
TEST=Check with standalone Files app, save dialog, open dialog
==========

to

==========
Hide non-native volumes when saving files from the browser.

Chrome browser opens Files app as a file saving dialog.  The caller of saving
dialog has a special handling for drive paths, but it does not handle other
non-native paths (e.g. FSP, MTP)

The CL lets Files app know which types of paths are handled by caller and hide
volumes that are not supported by caller.

BUG=581984
TEST=Check with standalone Files app, save dialog, open dialog

Committed: https://crrev.com/e820f8581d44df14269df140fc71d70adde7262b
Cr-Commit-Position: refs/heads/master@{#376073}
==========

[commit-bot: I haz the power, 2016-02-18 02:41:05]

Patchset 4 (id:??) landed as
https://crrev.com/e820f8581d44df14269df140fc71d70adde7262b
Cr-Commit-Position: refs/heads/master@{#376073}