Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1701153002: Fix linker errors when skia_ios target is used a dependency of an iOS app. (Closed)

Created:
4 years, 10 months ago by iroth
Modified:
4 years, 10 months ago
Reviewers:
dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix linker errors when skia_ios target is used a dependency of an iOS app. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1701153002 Committed: https://skia.googlesource.com/skia/+/ab669def65ce89aef724b8b88bd36c54c405d841

Patch Set 1 #

Patch Set 2 : Include SkImageDecoder_empty.cpp #

Total comments: 1

Patch Set 3 : Remove references to SkBitmapHasher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M public.bzl View 1 2 3 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
iroth
4 years, 10 months ago (2016-02-17 01:34:26 UTC) #3
mtklein
FYI: https://codereview.chromium.org/1704783002/ https://codereview.chromium.org/1701153002/diff/20001/public.bzl File public.bzl (right): https://codereview.chromium.org/1701153002/diff/20001/public.bzl#newcode89 public.bzl:89: "src/utils/SkBitmapHasher.cpp", Thanks for pointing this out. Gonna ...
4 years, 10 months ago (2016-02-17 02:16:00 UTC) #4
mtklein
lgtm!
4 years, 10 months ago (2016-02-17 02:51:23 UTC) #5
iroth
On 2016/02/17 02:16:00, mtklein wrote: > FYI: https://codereview.chromium.org/1704783002/ > > https://codereview.chromium.org/1701153002/diff/20001/public.bzl > File public.bzl (right): ...
4 years, 10 months ago (2016-02-17 02:53:01 UTC) #6
mtklein
On 2016/02/17 02:51:23, mtklein wrote: > lgtm! (time travel)
4 years, 10 months ago (2016-02-17 02:54:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701153002/40001
4 years, 10 months ago (2016-02-17 02:54:38 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 03:17:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ab669def65ce89aef724b8b88bd36c54c405d841

Powered by Google App Engine
This is Rietveld 408576698