Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1701103002: Add initial libfuzzers for fm2js transpiling and XML parsing. (Closed)

Created:
4 years, 10 months ago by Oliver Chang
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add initial libfuzzers for fm2js transpiling and XML parsing. GN source_sets are added so that the fuzzers can be built from //testing/libfuzzer in a Chromium checkout. GYP targets are also added to make sure these always build properly on our waterfall. These don't actually build the proper libfuzzers, but build the target fuzz function with a driver main() since the actual build process is quite complicated. R=tsepez@chromium.org, thestig@chromium.org BUG=587126 Committed: https://pdfium.googlesource.com/pdfium/+/e67d21825c9fd4b805b9bea211e09225f3c2a85d

Patch Set 1 #

Patch Set 2 : get rid of unnecessary GN import #

Patch Set 3 : don't build fuzzers on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -1 line) Patch
M build/all.gyp View 1 chunk +2 lines, -1 line 0 comments Download
A testing/libfuzzer/BUILD.gn View 1 1 chunk +51 lines, -0 lines 0 comments Download
A testing/libfuzzer/fuzzers.gyp View 1 2 1 chunk +65 lines, -0 lines 0 comments Download
A testing/libfuzzer/pdf_fm2js_fuzzer.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A testing/libfuzzer/pdf_xml_fuzzer.cc View 1 chunk +76 lines, -0 lines 0 comments Download
A testing/libfuzzer/unittest_main.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Oliver Chang
ptal
4 years, 10 months ago (2016-02-16 19:05:06 UTC) #1
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-16 19:24:02 UTC) #2
Oliver Chang
(made a trivial change in ps#3 to disable building on Windows, which is unsupported)
4 years, 10 months ago (2016-02-16 19:41:30 UTC) #3
Oliver Chang
4 years, 10 months ago (2016-02-16 19:42:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e67d21825c9fd4b805b9bea211e09225f3c2a85d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698