Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: components/arc/arc_bridge_service.h

Issue 1701063003: Refactor ArcBridgeService detection and initialization to a separate class ArcServiceLauncher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer feedback Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/arc_bridge_service.h
diff --git a/components/arc/arc_bridge_service.h b/components/arc/arc_bridge_service.h
index 56179d0287cefcf5a19a29de2272b2342c9bd5ec..9f95b18a339b81835cb0b80347ceff30933e42b0 100644
--- a/components/arc/arc_bridge_service.h
+++ b/components/arc/arc_bridge_service.h
@@ -131,10 +131,10 @@ class ArcBridgeService : public ArcBridgeHost {
// switch.
static bool GetEnabled(const base::CommandLine* command_line);
- // DetectAvailability() should be called once D-Bus is available. It will
- // call CheckArcAvailability() on the session_manager. This can only be
- // called on the thread that this class was created on.
- virtual void DetectAvailability() = 0;
+ // SetDetectionResult() should be called once CheckArcAvailability() on the
+ // session_manager is called. This can only be called on the thread that this
+ // class was created on.
+ virtual void SetDetectionResult(bool availability) = 0;
xiyuan 2016/02/26 17:38:01 nit: SetDetectionResult -> SetDetectedAvailability
arthurhsu 2016/02/26 19:10:06 Done
// HandleStartup() should be called upon profile startup. This will only
// launch an instance if the instance service is available and it is enabled.

Powered by Google App Engine
This is Rietveld 408576698