components/devtools_http_handler/devtools_http_handler.cc - Issue 1701063002: CookieStore: Remove reference counting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_http_handler/devtools_http_handler.cc

Issue 1701063002: CookieStore: Remove reference counting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@threadsafe

Patch Set: Fix leak Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/devtools_http_handler/devtools_http_handler.cc

diff --git a/components/devtools_http_handler/devtools_http_handler.cc b/components/devtools_http_handler/devtools_http_handler.cc

index 9c61964ba261c6242e77aabe4f93a9e4e98c1d3d..45a7ad8efea60eac0729c82549ba1bfc1c417b63 100644

--- a/components/devtools_http_handler/devtools_http_handler.cc

+++ b/components/devtools_http_handler/devtools_http_handler.cc

@@ -592,7 +592,9 @@ void DevToolsHttpHandler::OnJsonRequest(

if (command == "new") {

GURL url(net::UnescapeURLComponent(

- query, net::UnescapeRule::URL_SPECIAL_CHARS));

+ query,

+ net::UnescapeRule::PATH_SEPARATORS |

+ net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS));

if (!url.is_valid())

url = GURL(url::kAboutBlankURL);

scoped_ptr<DevToolsTargetDescriptor> descriptor =