CookieStore: Remove reference counting.

chrome/browser/profiles/profile_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_io_data.h"
 
 #include <stddef.h>
 #include <string>
 #include <utility>
 
@@ skipping 553 matching lines @@
 }
 
 ProfileIOData::MediaRequestContext::~MediaRequestContext() {
   AssertNoURLRequests();
 }
 
 ProfileIOData::AppRequestContext::AppRequestContext() {
 }
 
 void ProfileIOData::AppRequestContext::SetCookieStore(
-    net::CookieStore* cookie_store) {
-  cookie_store_ = cookie_store;
-  set_cookie_store(cookie_store);
+    scoped_ptr<net::CookieStore> cookie_store) {
+  cookie_store_ = std::move(cookie_store);
+  set_cookie_store(cookie_store_.get());

[Randy Smith (Not in Mondays), 2016/02/29 22:37:45]

Not part of this CL, but I think it's dangerously confusing that the base
URLRequestContext has "pointer but no ownership" semantics for the things in it,
and this derived class has ownership semantics.   Dunno whether that's on your
radar screen (or should be), but I'll mention my aversive reaction in case it
has any data in it.

[mmenke, 2016/02/29 23:00:29]

I'd really like to move to a world where all URLRequestContexts have ownership
semantics.  Sharing guts has gotten us into all sorts of trouble.  Sharing stuff
is actually the exception, rather than the rule.  The main request context
doesn't own its stuff, but all other request contexts (Except those that share
pars of the main one) own everything.  Suppose the system and proxy request
contexts also share components.

In this particular case, there's a bug on file about giving apps their own
separate URLRequestContexts, since sharing allows certain sidechannel attacks
(Don't know the specifics, beyond things like DNS timing attacks).

 }
 
 void ProfileIOData::AppRequestContext::SetHttpTransactionFactory(
     scoped_ptr<net::HttpTransactionFactory> http_factory) {
   http_factory_ = std::move(http_factory);
   set_http_transaction_factory(http_factory_.get());
 }
 
 void ProfileIOData::AppRequestContext::SetJobFactory(
     scoped_ptr<net::URLRequestJobFactory> job_factory) {
@@ skipping 735 matching lines @@
       make_scoped_ptr(new DevToolsNetworkTransactionFactory(
           network_controller_handle_.GetController(), shared_session)),
       std::move(backend), true /* set_up_quic_server_info */));
 }
 
 void ProfileIOData::SetCookieSettingsForTesting(
     content_settings::CookieSettings* cookie_settings) {
   DCHECK(!cookie_settings_.get());
   cookie_settings_ = cookie_settings;
 }