Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5693)

Unified Diff: chrome_elf/BUILD.gn

Issue 1701053002: gn/win: Try to get chrome_elf_unittests passing on swarming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: back to 1 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_elf/BUILD.gn
diff --git a/chrome_elf/BUILD.gn b/chrome_elf/BUILD.gn
index d251a106c68ea17d218960e9419b2f2739f1b5a4..218c2240a0fc86c3bd07196af7ebcd6e5a858097 100644
--- a/chrome_elf/BUILD.gn
+++ b/chrome_elf/BUILD.gn
@@ -137,16 +137,24 @@ test("chrome_elf_unittests") {
"//base",
"//base/test:run_all_unittests",
"//base/test:test_support",
+ "//chrome",
"//chrome/common:version_header",
"//sandbox",
"//testing/gtest",
]
+
+ # It's not easily possible to have //chrome in data_deps without changing
+ # the //chrome target to bundle up both initial/chrome.exe and chrome.exe.
+ # As a workaround, explicitly include a data dep on just chrome.exe, and
+ # add //chrome to deps above to make sure it's been built.
+ data = [
+ "$root_out_dir/chrome.exe",
+ ]
data_deps = [
":blacklist_test_dll_1",
":blacklist_test_dll_2",
":blacklist_test_dll_3",
":chrome_elf",
- "//chrome",
]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698