chrome/BUILD.gn - Issue 1701053002: gn/win: Try to get chrome_elf_unittests passing on swarming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 1701053002: gn/win: Try to get chrome_elf_unittests passing on swarming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: hmm Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index 3ebcf1329c2cc7b8354ebe439b6d4c1376b9f75b..a72734a2430a7ebfbccbc50f45b4ddf90105ef0e 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -63,6 +63,9 @@ if (!is_android) {

if (is_win) {

public_deps += [ ":reorder_imports" ]

}

+ data_deps = [

+ ":chrome_initial",

+ ]

Dirk Pranke 2016/02/16 19:57:44 I think this needs :reorder_imports as well on win

Nico 2016/02/16 20:08:20 Oh, and it should not have :chrome_initial on win,

}

executable("chrome_initial") {

« no previous file with comments | « no previous file | no next file » | no next file with comments »