sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart - Issue 170103003: Avoid use of empty string as a property name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

Issue 170103003: Avoid use of empty string as a property name. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/class_builder.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

index 49f51a9f54645409200fb2e8fde9025c2720a32b..9a6ca0b98e9b7eb6bab73ae4fe4d5fae7211f3d5 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

@@ -36,7 +36,7 @@ class ClassEmitter extends CodeEmitterHelper {

task.needsMixinSupport = true;

}

- ClassBuilder builder = new ClassBuilder();

+ ClassBuilder builder = new ClassBuilder(namer);

emitClassConstructor(classElement, builder, runtimeName,

onlyForRti: onlyForRti);

emitFields(classElement, builder, superName, onlyForRti: onlyForRti);

@@ -314,7 +314,7 @@ class ClassEmitter extends CodeEmitterHelper {

}

List<jsAst.Property> statics = new List<jsAst.Property>();

- ClassBuilder staticsBuilder = new ClassBuilder();

+ ClassBuilder staticsBuilder = new ClassBuilder(namer);

if (emitFields(classElement, staticsBuilder, null, emitStatics: true)) {

statics.add(staticsBuilder.toObjectInitializer().properties.single);

}