Issue 1701021: Bring 4554 to the 2.1 branch....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1701021: Bring 4554 to the 2.1 branch.... (Closed)

Created:
10 years, 7 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Kasper Lund

CC:
v8-dev, Mads Ager (chromium), laforge

Base URL:
http://v8.googlecode.com/svn/branches/2.1/

Visibility:
Public.

Description

Bring 4554 to the 2.1 branch. Use ScopedVector instead of dynamically allocated array. This ensures that it'll be released on any control path leaving the function thanks to desctuctor semantics. BUG=42925 Committed: http://code.google.com/p/v8/source/detail?r=4555

Patch Set 1 #

Patch Set 2 : version.cc updated #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	src/runtime.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

Kasper, may you have a look? Anthony, Mads, that goes to 2.1's head and thus ...

10 years, 7 months ago (2010-04-30 12:17:33 UTC) #1

LGTM.

Expand Messages | Collapse Messages