CrossThreadCopier: Consider arithmetic and enum types as safe.

CrossThreadCopier: Consider arithmetic and enum types as safe.

The original code assumed that types convertible to int were safe to
copy cross-thread. However, this condition is too narrow; any
arithmetic types (integers and floats) and enum types are actually
safe. This is fixed by this patch.

Additionally, this patch rearranges the order of CrossThreadCopierBase's
template parameters, because putting T in the last looks unusual. Also,
the specializations of CrossThreadCopierBase are updated so that the
readers can understand the specializations cover all the possible
combinations of template parameters (except for <T, false, false,
false>, which is intentionally undefined in the header).

BUG=565765
R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org

Committed: https://crrev.com/e17b74910a29f7db108c177670a9c0f15556ed33
Cr-Commit-Position: refs/heads/master@{#376129}

[Yuta Kitamura, 2016-02-17 07:13:35]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[Yuta Kitamura, 2016-02-17 07:14:06]

Description was changed from

==========
CrossThreadCopier: Consider arithmetic and enum types as safe.

The original code assumed that types convertible to int were safe to
copy cross-thread. However, this condition is too limited; any
arithmetic types (integers and floats) and enum types are actually
safe. This is fixed by this patch.

Additionally, this patch rearranges the order of CrossThreadCopierBase's
template parameters, because putting T in the last looks unusual. Also,
the specializations of CrossThreadCopierBase are updated so that the
readers can understand the specializations cover all the possible
combinations of template parameters (except for <T, false, false,
false>, which is intentionally undefined in the header).

BUG=565765
R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org
==========

to

==========
CrossThreadCopier: Consider arithmetic and enum types as safe.

The original code assumed that types convertible to int were safe to
copy cross-thread. However, this condition is too narrow; any
arithmetic types (integers and floats) and enum types are actually
safe. This is fixed by this patch.

Additionally, this patch rearranges the order of CrossThreadCopierBase's
template parameters, because putting T in the last looks unusual. Also,
the specializations of CrossThreadCopierBase are updated so that the
readers can understand the specializations cover all the possible
combinations of template parameters (except for <T, false, false,
false>, which is intentionally undefined in the header).

BUG=565765
R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org
==========

[commit-bot: I haz the power, 2016-02-17 07:14:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701013003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701013003/1

[Yuta Kitamura, 2016-02-17 07:15:07]

PTAL

[tzik, 2016-02-17 07:57:23]

lgtm

[haraken, 2016-02-17 08:04:24]

LGTM

[commit-bot: I haz the power, 2016-02-17 08:30:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 08:30:36]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-02-17 13:55:40]

lgtm.

[Yuta Kitamura, 2016-02-18 07:35:55]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2016-02-18 07:36:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701013003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701013003/1

[commit-bot: I haz the power, 2016-02-18 09:43:45]

Description was changed from

==========
CrossThreadCopier: Consider arithmetic and enum types as safe.

The original code assumed that types convertible to int were safe to
copy cross-thread. However, this condition is too narrow; any
arithmetic types (integers and floats) and enum types are actually
safe. This is fixed by this patch.

Additionally, this patch rearranges the order of CrossThreadCopierBase's
template parameters, because putting T in the last looks unusual. Also,
the specializations of CrossThreadCopierBase are updated so that the
readers can understand the specializations cover all the possible
combinations of template parameters (except for <T, false, false,
false>, which is intentionally undefined in the header).

BUG=565765
R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org
==========

to

==========
CrossThreadCopier: Consider arithmetic and enum types as safe.

The original code assumed that types convertible to int were safe to
copy cross-thread. However, this condition is too narrow; any
arithmetic types (integers and floats) and enum types are actually
safe. This is fixed by this patch.

Additionally, this patch rearranges the order of CrossThreadCopierBase's
template parameters, because putting T in the last looks unusual. Also,
the specializations of CrossThreadCopierBase are updated so that the
readers can understand the specializations cover all the possible
combinations of template parameters (except for <T, false, false,
false>, which is intentionally undefined in the header).

BUG=565765
R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org
==========

[commit-bot: I haz the power, 2016-02-18 09:43:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-18 09:45:21]

Description was changed from

==========
CrossThreadCopier: Consider arithmetic and enum types as safe.

The original code assumed that types convertible to int were safe to
copy cross-thread. However, this condition is too narrow; any
arithmetic types (integers and floats) and enum types are actually
safe. This is fixed by this patch.

Additionally, this patch rearranges the order of CrossThreadCopierBase's
template parameters, because putting T in the last looks unusual. Also,
the specializations of CrossThreadCopierBase are updated so that the
readers can understand the specializations cover all the possible
combinations of template parameters (except for <T, false, false,
false>, which is intentionally undefined in the header).

BUG=565765
R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org
==========

to

==========
CrossThreadCopier: Consider arithmetic and enum types as safe.

The original code assumed that types convertible to int were safe to
copy cross-thread. However, this condition is too narrow; any
arithmetic types (integers and floats) and enum types are actually
safe. This is fixed by this patch.

Additionally, this patch rearranges the order of CrossThreadCopierBase's
template parameters, because putting T in the last looks unusual. Also,
the specializations of CrossThreadCopierBase are updated so that the
readers can understand the specializations cover all the possible
combinations of template parameters (except for <T, false, false,
false>, which is intentionally undefined in the header).

BUG=565765
R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org

Committed: https://crrev.com/e17b74910a29f7db108c177670a9c0f15556ed33
Cr-Commit-Position: refs/heads/master@{#376129}
==========

[commit-bot: I haz the power, 2016-02-18 09:45:22]

Patchset 1 (id:??) landed as
https://crrev.com/e17b74910a29f7db108c177670a9c0f15556ed33
Cr-Commit-Position: refs/heads/master@{#376129}