Issue 1701001: Attach a "foreign" thread to NSPR as a "system" thread so that...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1701001: Attach a "foreign" thread to NSPR as a "system" thread so that... (Closed)

Created:
10 years, 8 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Attach a "foreign" thread to NSPR as a "system" thread so that PR_Cleanup doesn't need to wait for it to terminate. This works around a problem with thread local storage destructors in the official Windows builds, which enable whole program optimization. R=agl BUG=40663 TEST=Run chrome.exe with the --use-nss-for-ssl option on Windows. Use SSL. Shut down Chrome. All chrome.exe processes should terminate. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45059

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -1 line)			Patch
M	third_party/nss/README.chromium	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	third_party/nss/mozilla/nsprpub/pr/src/md/windows/w95thred.c	View	1 chunk	+1 line, -1 line	0 comments	Download
A	third_party/nss/patches/nspr-attach-as-system-thread.patch	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages