Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 1700963003: [Swarming] Make gcmole wrapper cwd-independent. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Swarming] Make gcmole wrapper cwd-independent. Some parts of the wrapped scripts seem to expect cwd to be the v8 directory. BUG=chromium:535160 LOG=n TBR=tandrii@chromium.org, kjellander@chromium.org, mstarzinger@chromium.org NOTRY=true Committed: https://crrev.com/4fbca26cde10237b0333e4296302ea6bc436a52d Cr-Commit-Position: refs/heads/master@{#34059}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gcmole/run-gcmole.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
TBR
4 years, 10 months ago (2016-02-17 08:37:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700963003/20001
4 years, 10 months ago (2016-02-17 08:38:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 08:39:49 UTC) #7
kjellander_chromium
lgtm
4 years, 10 months ago (2016-02-17 08:39:51 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 08:40:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4fbca26cde10237b0333e4296302ea6bc436a52d
Cr-Commit-Position: refs/heads/master@{#34059}

Powered by Google App Engine
This is Rietveld 408576698