Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1700953002: Revert of [tools] add --pretty switch to run_perf.py (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [tools] add --pretty switch to run_perf.py (patchset #8 id:140001 of https://codereview.chromium.org/1681283004/ ) Reason for revert: [Sheriff] Still fails on android. Original issue's description: > reland [tools] add --pretty switch to run_perf.py > > This CL improves running our internal benchmarks locally by adding the > --pretty option to tools/run_perf.py. With the flag enabled we print > the run-time of each benchmark directly and avoid the json output at > the end. > > NOTRY=true > > Committed: https://crrev.com/b543c40d78c3aa8283a7d9fccb6c9e26a9a81f90 > Cr-Commit-Position: refs/heads/master@{#34023} TBR=cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/4a58b46e55746d37f40527c15162d881ddeeda4b Cr-Commit-Position: refs/heads/master@{#34033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -113 lines) Patch
M tools/run_perf.py View 12 chunks +13 lines, -112 lines 0 comments Download
M tools/unittests/run_perf_test.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of [tools] add --pretty switch to run_perf.py
4 years, 10 months ago (2016-02-16 12:56:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700953002/1
4 years, 10 months ago (2016-02-16 12:56:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 12:56:26 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 12:56:51 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a58b46e55746d37f40527c15162d881ddeeda4b
Cr-Commit-Position: refs/heads/master@{#34033}

Powered by Google App Engine
This is Rietveld 408576698