Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 170093002: roll skia DEPS to 13482 (Closed)

Created:
6 years, 10 months ago by robertphillips
Modified:
6 years, 10 months ago
Reviewers:
bsalomon, rmistry, reed1
CC:
chromium-reviews, skia-review_google.com
Visibility:
Public.

Description

roll skia DEPS to 13482 Chromium base revision: 251714 / 7fcea678 Old Skia revision: 13441 New Skia revision: 13482 Control CL: https://codereview.chromium.org/169283009 This CL was created by Skia's roll_deps.py script. Bypassing commit queue trybots: NOTRY=true R=reed@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251775

Patch Set 1 #

Patch Set 2 : Added suppressions #

Patch Set 3 : Added #define #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M DEPS View 1 1 chunk +2 lines, -2 lines 0 comments Download
M skia/skia_common.gypi View 1 2 1 chunk +2 lines, -0 lines 2 comments Download
M skia/skia_test_expectations.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
This roll is blocked on the following layout tests which are failing across the board: ...
6 years, 10 months ago (2014-02-18 13:43:55 UTC) #1
reed1
lgtm https://codereview.chromium.org/170093002/diff/130001/skia/skia_common.gypi File skia/skia_common.gypi (right): https://codereview.chromium.org/170093002/diff/130001/skia/skia_common.gypi#newcode198 skia/skia_common.gypi:198: 'SK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT', Is this visible to clients?
6 years, 10 months ago (2014-02-18 14:07:46 UTC) #2
robertphillips
https://codereview.chromium.org/170093002/diff/130001/skia/skia_common.gypi File skia/skia_common.gypi (right): https://codereview.chromium.org/170093002/diff/130001/skia/skia_common.gypi#newcode198 skia/skia_common.gypi:198: 'SK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT', It is a Skia-facing #define so will not ...
6 years, 10 months ago (2014-02-18 14:09:31 UTC) #3
robertphillips
Committed patchset #3 manually as r251775 (presubmit successful).
6 years, 10 months ago (2014-02-18 16:39:44 UTC) #4
robertphillips
This was reverted in 251793 (Revert 251775 "roll skia DEPS to 13482" - https://codereview.chromium.org/170923002/) due ...
6 years, 10 months ago (2014-02-18 20:42:11 UTC) #5
robertphillips
6 years, 10 months ago (2014-02-18 20:46:12 UTC) #6
Message was sent while issue was closed. 
Here is the call stack from the Linux Clang bot:

@@@STEP_LOG_LINE@SelectionKeepsLigatures@RenderTextTest.SelectionKeepsLigatures
(run #3):@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@[ RUN      ]
RenderTextTest.SelectionKeepsLigatures@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@[11586:11586:0218/100508:1164294824:FATAL:SkBitmap.cpp(517)]
../../third_party/skia/src/core/SkBitmap.cpp:517: failed assertion
"this->getPixels()"@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x7f8d49be3fbe]
base::debug::StackTrace::StackTrace()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x7f8d49c66f25]
logging::LogMessage::~LogMessage()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x7f8d4a411c51]
SkDebugf_FileLine()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x7f8d4a1f7ac8]
SkBitmap::installPixels()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x7f8d4a4034ef] skia::(anonymous
namespace)::InstallCairoSurfacePixels()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x7f8d4a403384]
skia::BitmapPlatformDevice::Create()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x7f8d4a403716]
skia::BitmapPlatformDevice::Create()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x7f8d4a403b54]
skia::CreatePlatformCanvas()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x7f8d4a94ab08]
skia::CreatePlatformCanvas()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x7f8d4a94ace7]
gfx::Canvas::Canvas()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x000000587ab5]
gfx::RenderTextTest_SelectionKeepsLigatures_Test::TestBody()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x00000066f023]
testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x00000065bb0e]
testing::internal::HandleExceptionsInMethodIfSupported\u003C>()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x000000651eb5]
testing::Test::Run()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x0000006525cb]
testing::TestInfo::Run()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x000000652bba]
testing::TestCase::Run()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x0000006571c8]
testing::internal::UnitTestImpl::RunAllTests()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x000000667963]
testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x00000065d90e]
testing::internal::HandleExceptionsInMethodIfSupported\u003C>()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x000000656e54]
testing::UnitTest::Run()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x000000616051] RUN_ALL_TESTS()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x000000614fe7]
base::TestSuite::Run()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x000000499a62]
base::internal::RunnableAdapter\u003C>::Run()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x0000004996ef]
base::internal::InvokeHelper\u003C>::MakeItSo()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x00000049969a]
base::internal::Invoker\u003C>::Run()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x00000060e54e]
base::Callback\u003C>::Run()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x00000060ae9e] base::(anonymous
namespace)::LaunchUnitTestsInternal()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x00000060ab90]
base::LaunchUnitTests()@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x00000049942d] main@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x7f8d4719376d] __libc_start_main@@@
@@@STEP_LOG_LINE@SelectionKeepsLigatures@ [0x000000428429] \u003Cunknown>@@@

Powered by Google App Engine
This is Rietveld 408576698