Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1700923002: Move FieldType to separate h/cc files. (Closed)

Created:
4 years, 10 months ago by Jarin
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Toon Verwaest
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move FieldType to separate h/cc files. Committed: https://crrev.com/75cdb913669f24ae2c851aa393c24c7d9085951f Cr-Commit-Position: refs/heads/master@{#34026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -118 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ast/ast-expression-rewriter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ast/ast-expression-visitor.h View 1 chunk +0 lines, -2 lines 0 comments Download
A src/field-type.h View 1 chunk +42 lines, -0 lines 0 comments Download
A src/field-type.cc View 1 chunk +102 lines, -0 lines 0 comments Download
M src/json-parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/property.h View 1 chunk +1 line, -1 line 0 comments Download
M src/types.h View 1 chunk +0 lines, -24 lines 0 comments Download
M src/types.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 10 months ago (2016-02-16 09:36:59 UTC) #2
Benedikt Meurer
lgtm
4 years, 10 months ago (2016-02-16 10:20:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700923002/1
4 years, 10 months ago (2016-02-16 10:21:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 10:22:29 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 10:22:44 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/75cdb913669f24ae2c851aa393c24c7d9085951f
Cr-Commit-Position: refs/heads/master@{#34026}

Powered by Google App Engine
This is Rietveld 408576698