editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java - Issue 17009007: Tweak j2d for String.indexOf(s,int) semantics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java

Issue 17009007: Tweak j2d for String.indexOf(s,int) semantics. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/ObjectSemanticProcessor.java ('k') | pkg/analyzer_experimental/lib/src/generated/java_core.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java

diff --git a/editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java b/editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java

index 111b7ef78047b6e6bd6bdb0848e28ef6439d1ed8..87e4e8e317d1ea41cc0aa6964076248f23ed3fdc 100644

--- a/editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java

+++ b/editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java

@@ -833,9 +833,40 @@ public class ObjectSemanticProcessorTest extends SemanticProcessorTest {

"class Test {",

" void main(String s) {",

" s.indexOf('1');",

- " s.indexOf('2', 42);",

+ " JavaString.indexOf(s, '2', 42);",

" s.lastIndexOf('1');",

- " s.lastIndexOf('2', 42);",

+ " JavaString.lastIndexOf(s, '2', 42);",

+ " }",

+ "}");

+ }

+ /**

+ * In Java using invalid index given {@code -1}, but in Dart - exception.

+ */

+ public void test_String_indexOf_fromIndex() throws Exception {

+ translateSingleFile(

+ "// filler filler filler filler filler filler filler filler filler filler",

+ "package test;",

+ "public class Test {",

+ " public void main(String s) {",

+ " s.indexOf(\"x\", -1);",

+ " s.indexOf(\"x\", 10);",

+ " s.indexOf('y', 10);",

+ " s.lastIndexOf(\"x\", -1);",

+ " s.lastIndexOf(\"x\", 10);",

+ " s.lastIndexOf('y', 10);",

+ " }",

+ "}");

+ runProcessor();

+ assertFormattedSource(

+ "class Test {",

+ " void main(String s) {",

+ " JavaString.indexOf(s, \"x\", -1);",

+ " JavaString.indexOf(s, \"x\", 10);",

+ " JavaString.indexOf(s, 'y', 10);",

+ " JavaString.lastIndexOf(s, \"x\", -1);",

+ " JavaString.lastIndexOf(s, \"x\", 10);",

+ " JavaString.lastIndexOf(s, 'y', 10);",

" }",

"}");

}