Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 1700743003: Record whether and why the media default controls are being shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-controls-usecount
Patch Set: review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
index e6741a883068274ca5de8f7ed99653c217296099..610750d1bc2b8dc29b87058bb2cdf346f9ae84a7 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
@@ -68,6 +68,11 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement, public WillBeHeapSupple
public:
static WebMimeRegistry::SupportsType supportsType(const ContentType&);
+ enum class RecordMetricsBehavior {
+ DoNotRecord,
+ DoRecord
+ };
+
static void setMediaStreamRegistry(URLRegistry*);
static bool isMediaStreamURL(const String& url);
@@ -132,7 +137,6 @@ public:
TimeRanges* seekable() const;
bool ended() const;
bool autoplay() const;
- enum class RecordMetricsBehavior { DoNotRecord, DoRecord };
bool shouldAutoplay(const RecordMetricsBehavior = RecordMetricsBehavior::DoNotRecord);
bool loop() const;
void setLoop(bool);
@@ -150,7 +154,7 @@ public:
void durationChanged(double duration, bool requestSeek);
// controls
- bool shouldShowControls() const;
+ bool shouldShowControls(const RecordMetricsBehavior = RecordMetricsBehavior::DoNotRecord) const;
double volume() const;
void setVolume(double, ExceptionState&);
bool muted() const;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698