Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 1700743003: Record whether and why the media default controls are being shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-controls-usecount
Patch Set: review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
index 6d9157f8db8f8c50a7e3d6a60212167a8dedaf9e..41472e1ab66ad61f5494c5f1c21fcb959ca8b4f5 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
@@ -445,6 +445,8 @@ private:
// TODO(liberato): remove once autoplay gesture override experiment concludes.
void triggerAutoplayViewportCheckForTesting();
+ bool shouldShowControlsInternal(bool record) const;
sof 2016/02/18 16:12:17 We prefer using enums rather bools in Blink.
philipj_slow 2016/02/19 04:05:43 Yes, see `enum class RecordMetricsBehavior { DoNot
mlamouri (slow - plz ping) 2016/02/23 18:42:13 Re-used this enum. My understanding was that Chrom
+
UnthrottledTimer<HTMLMediaElement> m_loadTimer;
UnthrottledTimer<HTMLMediaElement> m_progressEventTimer;
UnthrottledTimer<HTMLMediaElement> m_playbackProgressTimer;

Powered by Google App Engine
This is Rietveld 408576698