Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 1700743003: Record whether and why the media default controls are being shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-controls-usecount
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
index e78e237e5fd378fe3dd1430bdd455906ad4f9cad..7692c8abc5647945621c9430119d242bc60ad355 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
@@ -282,6 +282,7 @@ void MediaControls::show()
void MediaControls::mediaElementFocused()
{
+ mediaElement().recordShowControls();
philipj_slow 2016/02/16 06:20:27 This case is akin to the mouse moving over the vid
mlamouri (slow - plz ping) 2016/02/18 15:49:31 Removed.
if (mediaElement().shouldShowControls()) {
show();
resetHideMediaControlsTimer();

Powered by Google App Engine
This is Rietveld 408576698