Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1700743003: Record whether and why the media default controls are being shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-controls-usecount
Patch Set: review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 61836640f95115657c7b5ec36055aed7e9f4e9c6..9129f4ba171aadd9058795696e056135557aa788 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -19187,6 +19187,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Media.Controls.Show" enum="MediaDefaultControlsReason">
philipj_slow 2016/02/19 04:05:43 I'd remove "default" everywhere in this file as we
mlamouri (slow - plz ping) 2016/02/23 18:42:13 Done. Renamed to MediaControlsShowReason.
+ <owner>mlamouri@chromium.org</owner>
+ <summary>
+ Record whether the default media controls where shown and why every time
+ they could be shown.
+ </summary>
+</histogram>
+
<histogram name="Media.CrosBeamformingDeviceState"
enum="CrosBeamformingDeviceState">
<owner>ajm@chromium.org</owner>
@@ -72338,6 +72346,13 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="39" label="SmoothStream"/>
</enum>
+<enum name="MediaDefaultControlsReason" type="int">
+ <int value="0" label="Default controls from attribute"/>
+ <int value="1" label="Default controls because fullscreen"/>
+ <int value="2" label="Default controls because no scripts allowed"/>
+ <int value="3" label="No default controls"/>
+</enum>
+
<enum name="MediaElementAutoPlay" type="int">
<int value="0" label="Media element with autoplay seen"/>
<int value="1"

Powered by Google App Engine
This is Rietveld 408576698