Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1700743002: Merge most of LayoutBox::mapLocalToAncestor() into LayoutObject. (Closed)

Created:
4 years, 10 months ago by mstensho (USE GERRIT)
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge most of LayoutBox::mapLocalToAncestor() into LayoutObject. Just kept the part that updates the IsFixed MapCoordinatesMode, since it wasn't intertwined with the rest and is unique to LayoutBox-derived classes. BUG=568492 R=leviw@chromium.org Committed: https://crrev.com/22a7baaee30e91be8e9283b8e3e49412589092fa Cr-Commit-Position: refs/heads/master@{#376126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -46 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +1 line, -41 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +14 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mstensho (USE GERRIT)
4 years, 10 months ago (2016-02-15 13:50:00 UTC) #1
leviw_travelin_and_unemployed
\o\ \o/ /o/ LGTM!
4 years, 10 months ago (2016-02-18 00:49:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700743002/1
4 years, 10 months ago (2016-02-18 00:49:32 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/160200)
4 years, 10 months ago (2016-02-18 01:06:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700743002/1
4 years, 10 months ago (2016-02-18 08:36:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 09:04:28 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 09:05:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22a7baaee30e91be8e9283b8e3e49412589092fa
Cr-Commit-Position: refs/heads/master@{#376126}

Powered by Google App Engine
This is Rietveld 408576698