Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: src/property-details.h

Issue 170073003: Consistent use of const for LookupResult. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/property.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 PropertyDetails(PropertyAttributes attributes, 226 PropertyDetails(PropertyAttributes attributes,
227 PropertyType type, 227 PropertyType type,
228 Representation representation, 228 Representation representation,
229 int field_index = 0) { 229 int field_index = 0) {
230 value_ = TypeField::encode(type) 230 value_ = TypeField::encode(type)
231 | AttributesField::encode(attributes) 231 | AttributesField::encode(attributes)
232 | RepresentationField::encode(EncodeRepresentation(representation)) 232 | RepresentationField::encode(EncodeRepresentation(representation))
233 | FieldIndexField::encode(field_index); 233 | FieldIndexField::encode(field_index);
234 } 234 }
235 235
236 int pointer() { return DescriptorPointer::decode(value_); } 236 int pointer() const { return DescriptorPointer::decode(value_); }
237 237
238 PropertyDetails set_pointer(int i) { return PropertyDetails(value_, i); } 238 PropertyDetails set_pointer(int i) { return PropertyDetails(value_, i); }
239 239
240 PropertyDetails CopyWithRepresentation(Representation representation) { 240 PropertyDetails CopyWithRepresentation(Representation representation) const {
241 return PropertyDetails(value_, representation); 241 return PropertyDetails(value_, representation);
242 } 242 }
243 PropertyDetails CopyAddAttributes(PropertyAttributes new_attributes) { 243 PropertyDetails CopyAddAttributes(PropertyAttributes new_attributes) {
244 new_attributes = 244 new_attributes =
245 static_cast<PropertyAttributes>(attributes() | new_attributes); 245 static_cast<PropertyAttributes>(attributes() | new_attributes);
246 return PropertyDetails(value_, new_attributes); 246 return PropertyDetails(value_, new_attributes);
247 } 247 }
248 248
249 // Conversion for storing details as Object*. 249 // Conversion for storing details as Object*.
250 explicit inline PropertyDetails(Smi* smi); 250 explicit inline PropertyDetails(Smi* smi);
251 inline Smi* AsSmi(); 251 inline Smi* AsSmi() const;
252 252
253 static uint8_t EncodeRepresentation(Representation representation) { 253 static uint8_t EncodeRepresentation(Representation representation) {
254 return representation.kind(); 254 return representation.kind();
255 } 255 }
256 256
257 static Representation DecodeRepresentation(uint32_t bits) { 257 static Representation DecodeRepresentation(uint32_t bits) {
258 return Representation::FromKind(static_cast<Representation::Kind>(bits)); 258 return Representation::FromKind(static_cast<Representation::Kind>(bits));
259 } 259 }
260 260
261 PropertyType type() { return TypeField::decode(value_); } 261 PropertyType type() const { return TypeField::decode(value_); }
262 262
263 PropertyAttributes attributes() const { 263 PropertyAttributes attributes() const {
264 return AttributesField::decode(value_); 264 return AttributesField::decode(value_);
265 } 265 }
266 266
267 int dictionary_index() { 267 int dictionary_index() const {
268 return DictionaryStorageField::decode(value_); 268 return DictionaryStorageField::decode(value_);
269 } 269 }
270 270
271 Representation representation() { 271 Representation representation() const {
272 ASSERT(type() != NORMAL); 272 ASSERT(type() != NORMAL);
273 return DecodeRepresentation(RepresentationField::decode(value_)); 273 return DecodeRepresentation(RepresentationField::decode(value_));
274 } 274 }
275 275
276 int field_index() { 276 int field_index() const {
277 return FieldIndexField::decode(value_); 277 return FieldIndexField::decode(value_);
278 } 278 }
279 279
280 inline PropertyDetails AsDeleted(); 280 inline PropertyDetails AsDeleted() const;
281 281
282 static bool IsValidIndex(int index) { 282 static bool IsValidIndex(int index) {
283 return DictionaryStorageField::is_valid(index); 283 return DictionaryStorageField::is_valid(index);
284 } 284 }
285 285
286 bool IsReadOnly() const { return (attributes() & READ_ONLY) != 0; } 286 bool IsReadOnly() const { return (attributes() & READ_ONLY) != 0; }
287 bool IsDontDelete() const { return (attributes() & DONT_DELETE) != 0; } 287 bool IsDontDelete() const { return (attributes() & DONT_DELETE) != 0; }
288 bool IsDontEnum() const { return (attributes() & DONT_ENUM) != 0; } 288 bool IsDontEnum() const { return (attributes() & DONT_ENUM) != 0; }
289 bool IsDeleted() const { return DeletedField::decode(value_) != 0;} 289 bool IsDeleted() const { return DeletedField::decode(value_) != 0;}
290 290
(...skipping 29 matching lines...) Expand all
320 PropertyDetails(int value, PropertyAttributes attributes) { 320 PropertyDetails(int value, PropertyAttributes attributes) {
321 value_ = AttributesField::update(value, attributes); 321 value_ = AttributesField::update(value, attributes);
322 } 322 }
323 323
324 uint32_t value_; 324 uint32_t value_;
325 }; 325 };
326 326
327 } } // namespace v8::internal 327 } } // namespace v8::internal
328 328
329 #endif // V8_PROPERTY_DETAILS_H_ 329 #endif // V8_PROPERTY_DETAILS_H_
OLDNEW
« no previous file with comments | « src/property.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698