Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 170073002: Define ARCH_X86_32 and ARCH_X86_64 (Closed)

Created:
6 years, 10 months ago by haltonhuo
Modified:
6 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Define ARCH_X86_32 and ARCH_X86_64 X86_32 is never used assembly files(*.asm, *.inc), define ARCH_X86_64 or ARCH_X86_32 instead. BUG=None TEST=build and run chrome and content_shell with media tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M media/media.gyp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
haltonhuo
6 years, 10 months ago (2014-02-18 00:55:27 UTC) #1
DaleCurtis
Nice catch, looking through the sources this seems correct. I suspect this will enable some ...
6 years, 10 months ago (2014-02-18 18:56:50 UTC) #2
DaleCurtis
Oh, lgtm
6 years, 10 months ago (2014-02-18 18:56:56 UTC) #3
haltonhuo
The CQ bit was checked by halton.huo@intel.com
6 years, 10 months ago (2014-02-19 01:35:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/halton.huo@intel.com/170073002/1
6 years, 10 months ago (2014-02-19 01:53:55 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 06:44:27 UTC) #6
Message was sent while issue was closed.
Change committed as 251977

Powered by Google App Engine
This is Rietveld 408576698