Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1700723002: Tidy heap snapshotting implementation. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy heap snapshotting implementation. Adjust the division of labor between BaseHeap::takeSnapshot() and the heap page implementations of takeSnapshot() -- - have BaseHeap::takeSnapshot() handle creation of page dump objects (and their naming scheme.) - tally the heap free count+size in a separate object; only added to by "normal" heap pages. R= BUG= Committed: https://crrev.com/82367d67cd40cdfd83af0009ad1623fde1703bd9 Cr-Commit-Position: refs/heads/master@{#375455}

Patch Set 1 #

Patch Set 2 : zero initialize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapPage.h View 1 4 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 4 chunks +13 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 10 months ago (2016-02-15 11:56:04 UTC) #2
haraken
LGTM
4 years, 10 months ago (2016-02-15 12:17:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700723002/20001
4 years, 10 months ago (2016-02-15 12:43:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-15 14:05:08 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:49:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82367d67cd40cdfd83af0009ad1623fde1703bd9
Cr-Commit-Position: refs/heads/master@{#375455}

Powered by Google App Engine
This is Rietveld 408576698