Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: src/debug/debug.js

Issue 1700693002: [debugger] fix debug command processor wrt restart frame. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function (global, utils) { 5 (function (global, utils) {
6 "use strict"; 6 "use strict";
7 7
8 // ---------------------------------------------------------------------------- 8 // ----------------------------------------------------------------------------
9 // Imports 9 // Imports
10 10
(...skipping 2297 matching lines...) Expand 10 before | Expand all | Expand 10 after
2308 if (frame_number < 0 || frame_number >= this.exec_state_.frameCount()) { 2308 if (frame_number < 0 || frame_number >= this.exec_state_.frameCount()) {
2309 return response.failed('Invalid frame "' + frame + '"'); 2309 return response.failed('Invalid frame "' + frame + '"');
2310 } 2310 }
2311 // Restart specified frame. 2311 // Restart specified frame.
2312 frame_mirror = this.exec_state_.frame(frame_number); 2312 frame_mirror = this.exec_state_.frame(frame_number);
2313 } else { 2313 } else {
2314 // Restart selected frame. 2314 // Restart selected frame.
2315 frame_mirror = this.exec_state_.frame(); 2315 frame_mirror = this.exec_state_.frame();
2316 } 2316 }
2317 2317
2318 var result_description = Debug.LiveEdit.RestartFrame(frame_mirror); 2318 var result_description = frame_mirror.restart();
2319 response.body = {result: result_description}; 2319 response.body = {result: result_description};
2320 }; 2320 };
2321 2321
2322 2322
2323 DebugCommandProcessor.prototype.debuggerFlagsRequest_ = function(request, 2323 DebugCommandProcessor.prototype.debuggerFlagsRequest_ = function(request,
2324 response) { 2324 response) {
2325 // Check for legal request. 2325 // Check for legal request.
2326 if (!request.arguments) { 2326 if (!request.arguments) {
2327 response.failed('Missing arguments'); 2327 response.failed('Missing arguments');
2328 return; 2328 return;
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
2522 "IsBreakPointTriggered", IsBreakPointTriggered, 2522 "IsBreakPointTriggered", IsBreakPointTriggered,
2523 "UpdateScriptBreakPoints", UpdateScriptBreakPoints, 2523 "UpdateScriptBreakPoints", UpdateScriptBreakPoints,
2524 ]); 2524 ]);
2525 2525
2526 // Export to liveedit.js 2526 // Export to liveedit.js
2527 utils.Export(function(to) { 2527 utils.Export(function(to) {
2528 to.GetScriptBreakPoints = GetScriptBreakPoints; 2528 to.GetScriptBreakPoints = GetScriptBreakPoints;
2529 }); 2529 });
2530 2530
2531 }) 2531 })
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698