[Swarming] Isolate valgrind runner.

tools/run-valgrind.isolate

+# Copyright 2016 the V8 project authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+{
+  'variables': {
+    'command': [
+      'run-valgrind.py',
+    ],
+    'files': [
+      'run-valgrind.py',
+    ],
+  },
+  'conditions': [
+    ['has_valgrind==1', {
+      'variables': {
+        'files': [
+          # This assumes vagrind binaries have been fetched as a custom deps into

[kjellander_chromium, 2016/02/15 08:48:28]

nit: wrap at 80 chars.

[Michael Achenbach, 2016/02/15 09:55:45]

Done.

+          # v8/third_party/valgrind. It is not clear on which target machine this
+          # will run, but grabbing both is cheap.
+          '../third_party/valgrind/linux_x86/',

[kjellander_chromium, 2016/02/15 08:48:28]

You could use the target_arch variable for checks in the .isolate files. I
thought it was known which target machine architecture you'll run on - don't you
need to know that in order to avoid the risk of running a 64-bit binary on a
32-bit system?

[Michael Achenbach, 2016/02/15 09:55:45]

That way yes. But I could very well run a 32 bit binary in a 64 bit system. If
my target build is 64 bits, the target machine must be 64 as well, if my target
build is 32 bits, the target machine could be both (in theory - in practice, I
think all bots are 64 bits - but this doesn't cost much).

[kjellander_chromium, 2016/02/15 11:49:26]

Fair enough, simplicity is better.

+          '../third_party/valgrind/linux_x64/',
+        ],
+      },
+    }],
+  ],
+  'includes': [
+    '../src/d8.isolate',
+  ],
+}