build/has_valgrind.py - Issue 1700673002: [Swarming] Isolate valgrind runner.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/has_valgrind.py

Issue 1700673002: [Swarming] Isolate valgrind runner. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/usr/bin/env python

	2 # Copyright 2016 the V8 project authors. All rights reserved.

	3 # Use of this source code is governed by a BSD-style license that can be

	4 # found in the LICENSE file.

	5

	6 import os

	7

	8 BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))

	9 VALGRIND_DIR = os.path.join(BASE_DIR, 'third_party', 'valgrind')

	10 LINUX32_DIR = os.path.join(VALGRIND_DIR, 'linux_x86')

	11 LINUX64_DIR = os.path.join(VALGRIND_DIR, 'linux_x64')

	12
	kjellander_chromium 2016/02/15 08:48:28 two blank lines before top-level function two blank lines before top-level function Michael Achenbach 2016/02/15 09:55:45 Done. Show quoted text On 2016/02/15 08:48:28, kjellander (chromium) wrote: > two blank lines before top-level function Done.
	13 def DoMain(_):
	kjellander_chromium 2016/02/15 08:48:28 name this main(_): https://google.github.io/style name this main(_): https://google.github.io/styleguide/pyguide.html?showone=Main#Main Michael Achenbach 2016/02/15 09:55:45 Won't work. This is not the python main function b Show quoted text On 2016/02/15 08:48:28, kjellander (chromium) wrote: > name this main(_): > https://google.github.io/styleguide/pyguide.html?showone=Main#Main Won't work. This is not the python main function but a gyp hook. Gyp expects it to be called like that and calls the function directly with the pymod_do_main action in standalone.gypi. It is widely used https://code.google.com/p/chromium/codesearch#search/&q=pymod_do_main&sq=pack... and well documented as usual ;) kjellander_chromium 2016/02/15 11:49:26 Ah, I didn't pay attention to (or knew about) that Show quoted text On 2016/02/15 09:55:45, Michael Achenbach wrote: > On 2016/02/15 08:48:28, kjellander (chromium) wrote: > > name this main(_): > > https://google.github.io/styleguide/pyguide.html?showone=Main#Main > > Won't work. This is not the python main function but a gyp hook. Gyp expects it > to be called like that and calls the function directly with the pymod_do_main > action in standalone.gypi. It is widely used > https://code.google.com/p/chromium/codesearch#search/&q=pymod_do_main&sq=pack... > and well documented as usual ;) Ah, I didn't pay attention to (or knew about) that. Sorry - I should have known that you know how to name a main function ;)
	14 """Hook to be called from gyp without starting a separate python

	15 interpreter."""

	16 return int(os.path.exists(LINUX32_DIR) and os.path.exists(LINUX64_DIR))

	17
	kjellander_chromium 2016/02/15 08:48:28 +1 blank line +1 blank line Michael Achenbach 2016/02/15 09:55:45 Done. Show quoted text On 2016/02/15 08:48:28, kjellander (chromium) wrote: > +1 blank line Done.
	18 if __name__ == '__main__':

	19 print DoMain([])

OLD	NEW

« no previous file with comments | « build/all.gyp ('k') | build/isolate.gypi » ('j') | tools/run-valgrind.isolate » ('J')