Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1700583002: X87: [turbofan] Add RoundUint32ToFloat32 operator to Turbofan. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
Reviewers:
Weiliang, chunyang.dai, Jing
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Add RoundUint32ToFloat32 operator to Turbofan. port 187b3f2845a39f428ac46d72450373c678d011de (r33796) original commit message: BUG= Committed: https://crrev.com/d75ddc588e06e2fd948a6cdd60ebcaca8ce5d183 Cr-Commit-Position: refs/heads/master@{#33967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-14 06:04:00 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-14 14:18:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700583002/1
4 years, 10 months ago (2016-02-15 01:07:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 01:30:27 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 01:30:49 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d75ddc588e06e2fd948a6cdd60ebcaca8ce5d183
Cr-Commit-Position: refs/heads/master@{#33967}

Powered by Google App Engine
This is Rietveld 408576698