Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 1700533003: Fix MSAN warning on simulator during cpu profiling. (Closed)

Created:
4 years, 10 months ago by alph
Modified:
4 years, 10 months ago
Reviewers:
titzer, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix MSAN warning on simulator during cpu profiling. CPU profiler probes stack frame to find if it's in a valid state. Under simulator it might happen the frame is not initialized and MSAN repors that. That's totally ok. Suppress the warning. BUG=v8:4751 LOG=N Committed: https://crrev.com/c2abfe75ea5d6e4552791fd2a667b493a92ff387 Cr-Commit-Position: refs/heads/master@{#34061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/frames.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700533003/1
4 years, 10 months ago (2016-02-13 03:03:11 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-13 03:25:03 UTC) #4
alph
ptal
4 years, 10 months ago (2016-02-16 18:35:06 UTC) #6
titzer
lgtm
4 years, 10 months ago (2016-02-17 08:16:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700533003/1
4 years, 10 months ago (2016-02-17 08:40:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 09:08:03 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 09:08:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2abfe75ea5d6e4552791fd2a667b493a92ff387
Cr-Commit-Position: refs/heads/master@{#34061}

Powered by Google App Engine
This is Rietveld 408576698