Source/core/editing/FrameSelection.h - Issue 17005008: Don't show caret when containing element doesn't have focus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.h

Issue 17005008: Don't show caret when containing element doesn't have focus (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: 2013-06-28T14:12:48 Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/FrameSelection.h

diff --git a/Source/core/editing/FrameSelection.h b/Source/core/editing/FrameSelection.h

index 9a23674fb60cdb7c8ed7b8c47d81b02459c86029..ceceb267678e7f555cbb0cc764d206111496f415 100644

--- a/Source/core/editing/FrameSelection.h

+++ b/Source/core/editing/FrameSelection.h

@@ -192,6 +192,7 @@ public:

IntRect absoluteCaretBounds();

void setCaretRectNeedsUpdate() { CaretBase::setCaretRectNeedsUpdate(); }

+ void didFocusChanged();

tkent 2013/06/28 06:46:56 nit: The name should be didChangeFocus or focusWas

yosin_UTC9 2013/06/28 08:22:46 Done.

void willBeModified(EAlteration, SelectionDirection);

bool isNone() const { return m_selection.isNone(); }

@@ -291,6 +292,7 @@ private:

void setUseSecureKeyboardEntry(bool);

void setCaretVisibility(CaretVisibility);

+ bool shouldBlinkCaret() const;

bool dispatchSelectStart();