Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: runtime/vm/object.h

Issue 1700463002: Clone both descriptor and data array when compiling in background (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Reviewer's comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 9e6ba4209546f10f014100f3ed85cb96946e7e24..8fcc75c5864fab0f5ccf319eb8cd6ffce906ff1c 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -1941,11 +1941,8 @@ class ICData : public Object {
intptr_t num_args_tested);
static RawICData* NewFrom(const ICData& from, intptr_t num_args_tested);
- // Generates a new ICData with descriptor data copied (shallow clone).
- // Entry array of the result is the same as in 'from'. Once entry array is
- // created, it can only change the 'count', all other properties are invariant
- // (target, cids, number of checks).
- static RawICData* CloneDescriptor(const ICData& from);
+ // Generates a new ICData with descriptor and data array copied (deep clone).
+ static RawICData* Clone(const ICData& from);
static intptr_t TestEntryLengthFor(intptr_t num_args);
@@ -2681,9 +2678,9 @@ class Function : public Object {
const ZoneGrowableArray<const ICData*>& deopt_id_to_ic_data,
const Array& edge_counters_array) const;
// Uses 'ic_data_array' to populate the table 'deopt_id_to_ic_data'. Clone
- // descriptors if 'clone_descriptors' true.
+ // ic_data (array and descriptor) if 'clone_ic_data' is true.
void RestoreICDataMap(ZoneGrowableArray<const ICData*>* deopt_id_to_ic_data,
- bool clone_descriptors) const;
+ bool clone_ic_data) const;
RawArray* ic_data_array() const;
void ClearICDataArray() const;
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698