Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1700443003: Use the new mojom parser from check_mojom_dart.py. (Closed)

Created:
4 years, 10 months ago by rudominer
Modified:
4 years, 10 months ago
Reviewers:
Cutch, azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use the new mojom parser from check_mojom_dart.py. BUG=#671 This is part of my work to delete the old Mojom parser from the source tree. Currently the pre-submit script mojo/dart/tools/presubmit/check_mojom_dart.py directly invokes v1 of the parser in order to extract the module name and the 'DartPackage' attribute of a .mojom file. This CL changes check_mojom_dart.py to use the new parser. In support of that we also: - Create a new script in pylib called parser_runner.py that encapsulates invoking the parser and the translator. - Invoke this script from check_mojom_dart.py - Refactor run_code_generators.py and mojom_bindings_generator_v2.py to invoke parser_runner.py instead of having the logic directly embbedded in them. R=azani@chromium.org, johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/63a720b40073fcb15966102a7a45166c47193cf1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -54 lines) Patch
M mojo/dart/tools/presubmit/check_mojom_dart.py View 2 chunks +18 lines, -21 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator_v2.py View 2 chunks +6 lines, -29 lines 0 comments Download
A mojo/public/tools/bindings/pylib/mojom/parse/parser_runner.py View 1 chunk +127 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/run_code_generators.py View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
rudominer
Hi John and Alex, ptal. thanks, Mitch
4 years, 10 months ago (2016-02-17 05:09:35 UTC) #8
Cutch
lgtm
4 years, 10 months ago (2016-02-17 14:58:39 UTC) #10
azani
lgtm
4 years, 10 months ago (2016-02-17 17:14:48 UTC) #11
rudominer
4 years, 10 months ago (2016-02-17 17:15:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:100001) manually as
63a720b40073fcb15966102a7a45166c47193cf1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698