fixes #25793, make strong checker tests sane

fixes #25793, make strong checker tests sane
slight code change to pass through the options flag for strong hints

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/e60ff7619657ca97d16b8770da82392b54006c54

[Jennifer Messerly, 2016-02-17 01:15:29]

Description was changed from

==========
fixes #25793, make strong checker tests sane
==========

to

==========
fixes #25793, make strong checker tests sane
slight code change to pass through the options flag for strong hints
==========

[Jennifer Messerly, 2016-02-17 01:15:29]

jmesserly@google.com changed reviewers:
+ leafp@google.com, rnystrom@google.com

[Jennifer Messerly, 2016-02-17 01:16:54]

I'm going to rename "severe" to "error" too, but figured that would be easier in
its own diff :)

[Leaf, 2016-02-17 16:39:19]

lgtm

https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:370: h = new
B/*warning:NOT_ENOUGH_REQUIRED_ARGUMENTS*/();
Are these intentional or just an accident?  Maybe just pass in some ignored
constant?

https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:992:
/*severe:MISSING_CONST_FINAL_VAR_OR_TYPE*/a3;
I don't think this is intentional, probably just supposed to be static const?

https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1260: void
f0(List<int> a) {}
Oh Dart.  *sigh*

[Jennifer Messerly, 2016-02-17 16:40:44]

On 2016/02/17 16:39:19, Leaf wrote:
> lgtm
> 
>
https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
> File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):
> 
>
https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
> pkg/analyzer/test/src/task/strong/inferred_type_test.dart:370: h = new
> B/*warning:NOT_ENOUGH_REQUIRED_ARGUMENTS*/();
> Are these intentional or just an accident?  Maybe just pass in some ignored
> constant?
> 
>
https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
> pkg/analyzer/test/src/task/strong/inferred_type_test.dart:992:
> /*severe:MISSING_CONST_FINAL_VAR_OR_TYPE*/a3;
> I don't think this is intentional, probably just supposed to be static const?
> 
>
https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
> pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1260: void
> f0(List<int> a) {}
> Oh Dart.  *sigh*

Haha, yeah, I could never tell if our broken input code was intentional ;). Good
catch, I'll fix those!

[Jennifer Messerly, 2016-02-17 16:46:46]

Thanks again! Fixed those

https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:370: h = new
B/*warning:NOT_ENOUGH_REQUIRED_ARGUMENTS*/();
On 2016/02/17 16:39:19, Leaf wrote:
> Are these intentional or just an accident?  Maybe just pass in some ignored
> constant?

Done.

https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:992:
/*severe:MISSING_CONST_FINAL_VAR_OR_TYPE*/a3;
On 2016/02/17 16:39:19, Leaf wrote:
> I don't think this is intentional, probably just supposed to be static const?

Done.

https://codereview.chromium.org/1700403002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1260: void
f0(List<int> a) {}
On 2016/02/17 16:39:19, Leaf wrote:
> Oh Dart.  *sigh*

Dart loves semicolons. Except when it doesn't. ;)

[Leaf, 2016-02-17 17:00:15]

still lgtm

[Jennifer Messerly, 2016-02-17 17:06:56]

Description was changed from

==========
fixes #25793, make strong checker tests sane
slight code change to pass through the options flag for strong hints
==========

to

==========
fixes #25793, make strong checker tests sane
slight code change to pass through the options flag for strong hints

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e60ff7619657ca97d16b8770da82392b54006c54
==========

[Jennifer Messerly, 2016-02-17 17:06:58]

Committed patchset #2 (id:20001) manually as
e60ff7619657ca97d16b8770da82392b54006c54 (presubmit successful).