Issue 17004005: Remove staling file: SpeechSynthesisChromium.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17004005: Remove staling file: SpeechSynthesisChromium.cpp (Closed)

Created:
7 years, 6 months ago by kbalazs_

Modified:
7 years, 6 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@webdatabase_refactor

Visibility:
Public.

Remove staling file: SpeechSynthesisChromium.cpp Seems like it has just left over. Those methods are already implemented in SpeechSynthesisChromium.cpp. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152634

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -69 lines)			Patch
	D	Source/modules/speech/chromium/SpeechSynthesisChromium.cpp	View		1 chunk	+0 lines, -69 lines	0 comments	Download

Total messages: 6 (0 generated)

abarth-chromium

SpeechSynthesisChromium.cpp <--- Do you mean a different file? This is the one you're removing. LGTM

7 years, 6 months ago (2013-06-17 18:35:24 UTC) #2

kbalazs_

On 2013/06/17 18:35:51, abarth wrote: > "Remove staling file" --> "Remove used file" ? I ...

7 years, 6 months ago (2013-06-18 12:59:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/17004005/5001

7 years, 6 months ago (2013-06-18 13:00:16 UTC) #5

Message was sent while issue was closed.

Change committed as 152634