Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 17004: Experimental: add a has_valid_frame predicate to the code generator... (Closed)

Created:
11 years, 12 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Experimental: add a has_valid_frame predicate to the code generator and use it instead of "frame != NULL" everywhere. TBR: whesse Committed: http://code.google.com/p/v8/source/detail?r=1020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -60 lines) Patch
M src/codegen-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/codegen-ia32.cc View 26 chunks +52 lines, -53 lines 0 comments Download
M src/jump-target-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/register-allocator-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/virtual-frame-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 12 months ago (2008-12-29 11:02:17 UTC) #1
William Hesse
11 years, 12 months ago (2008-12-29 12:53:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698