[win/cros/lin] Update spellcheck menu strings according to UX.

chrome/browser/ui/webui/options/language_options_handler_common.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/language_options_handler_common.h"
 
 #include <stddef.h>
 
 #include <map>
 #include <string>
@@ skipping 62 matching lines @@
     { "displayInThisLanguage",
       IDS_OPTIONS_SETTINGS_LANGUAGES_DISPLAY_IN_THIS_LANGUAGE,
       product_id },
     { "restartRequired", IDS_OPTIONS_RELAUNCH_REQUIRED },
   // OS X uses the OS native spellchecker so no need for these strings.
 #if !defined(OS_MACOSX)
     { "useThisForSpellChecking",
       IDS_OPTIONS_SETTINGS_USE_THIS_FOR_SPELL_CHECKING },
     { "cannotBeUsedForSpellChecking",
       IDS_OPTIONS_SETTINGS_CANNOT_BE_USED_FOR_SPELL_CHECKING },
-    { "isUsedForSpellChecking",
-      IDS_OPTIONS_SETTINGS_IS_USED_FOR_SPELL_CHECKING },

[groby-ooo-7-16, 2016/02/18 03:06:36]

Uh, isn't that still used?
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

[please use gerrit instead, 2016/02/18 16:54:30]

Bad naming in language_options.js. The variable "isUsedForSpellChecking" that
you see in there is a local that's declared a few lines above:

    var isUsedForSpellchecking = languageCode in this.spellCheckLanguages_;

      spellCheckLanguageCheckbox.languageCode = languageCode;
      spellCheckLanguageCheckbox.checked = isUsedForSpellchecking;

The variable defined here in language_options_handler_common.cc can be accessed
in JavaScript only through loadTimeData.getString('isUsedForSpellchecking') and
in HTML through <span i18n-content="isUsedForSpellchecking"></span>. These do
not exist after single language spellcheck was deprecated.

     { "enableSpellCheck", IDS_OPTIONS_ENABLE_SPELLCHECK },
     { "downloadingDictionary", IDS_OPTIONS_DICTIONARY_DOWNLOADING },
     { "downloadFailed", IDS_OPTIONS_DICTIONARY_DOWNLOAD_FAILED },
     { "retryButton", IDS_OPTIONS_DICTIONARY_DOWNLOAD_RETRY },
     { "downloadFailHelp", IDS_OPTIONS_DICTIONARY_DOWNLOAD_FAIL_HELP },
 #endif  // !OS_MACOSX
     { "addLanguageTitle", IDS_OPTIONS_LANGUAGES_ADD_TITLE },
     { "addLanguageSelectLabel", IDS_OPTIONS_LANGUAGES_ADD_SELECT_LABEL },
     { "restartButton", IDS_OPTIONS_SETTINGS_LANGUAGES_RELAUNCH_BUTTON },
     { "offerToTranslateInThisLanguage",
@@ skipping 215 matching lines @@
       return;
     }
   }
 }
 
 SpellcheckService* LanguageOptionsHandlerCommon::GetSpellcheckService() {
   return SpellcheckServiceFactory::GetForContext(Profile::FromWebUI(web_ui()));
 }
 
 }  // namespace options