sdk/lib/_internal/compiler/implementation/ssa/codegen.dart - Issue 17003004: Fix a bug in how we deal HTypeConversion during type propagation: we must use the intersection betw…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 17003004: Fix a bug in how we deal HTypeConversion during type propagation: we must use the intersection betw… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 24215)

+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)

@@ -2494,6 +2494,9 @@

return;

}

if (node.isArgumentTypeCheck || node.isReceiverTypeCheck) {

+ // An int check if the input is not int or null, is not

+ // sufficient for doing a argument or receiver check.

+ assert(!node.isInteger() || node.checkedInput.isIntegerOrNull());

js.Expression test = generateTest(node);

js.Block oldContainer = currentContainer;

js.Statement body = new js.Block.empty();

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart » ('j') | no next file with comments »