Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 17003: Update UnloadReference to use new virtual frame. (Closed)

Created:
11 years, 11 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Update UnloadReference to use new virtual frame.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/codegen-ia32.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
Here is a small change, testing whether development on the Mac works. Tested with regular ...
11 years, 11 months ago (2008-12-29 10:43:55 UTC) #1
Kevin Millikin (Chromium)
I would go with even less external manipulation. What's happening (dropping some elements immediately below ...
11 years, 11 months ago (2008-12-29 11:00:52 UTC) #2
William Hesse
11 years, 11 months ago (2008-12-29 19:23:27 UTC) #3
I guess it doesn't hurt anything to add it.  I'll do that, as well as the other
changes from the previous list.


On 2008/12/29 11:00:52, Kevin Millikin wrote:
> I would go with even less external manipulation.  What's happening (dropping
> some elements immediately below the frame top while preserving the top) seems
> like a purely frame-internal operation.
> 
> Forth programmers would call it "nip".  We could use that name and we could
> allow it to take a non-negative integer argument that was the number of
elements
> to nip.

Powered by Google App Engine
This is Rietveld 408576698