Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2213)

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 1700273003: MD Settings: make <paper-drawer-panel> flip in RTL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_ui/settings_ui.js
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js
index 513aa521d503b1b8eb1d6d095bc93ad26bd5c73a..70e256b76b792df719030355e429c79d155da1c6 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js
@@ -23,4 +23,17 @@ Polymer({
*/
prefs: Object,
},
+
+ ready: function() {
+ assert(!document.documentElement.dir);
Dan Beam 2016/02/17 04:47:34 if this changes (i.e. dschuyler does <html dir="$i
+ this.listen(document, 'i18n-processed', 'onI18nProcessed_');
Dan Beam 2016/02/17 04:47:34 i can't use listeners because this doesn't bubble
michaelpg 2016/02/17 06:14:05 Why does this require waiting for this event at al
Dan Beam 2016/02/17 17:55:55 fixted it
+ },
+
+ /**
+ * @param {!Event} e
+ * @private
+ */
+ onI18nProcessed_: function(e) {
+ this.$.panel.rightDrawer = isRTL();
+ },
});

Powered by Google App Engine
This is Rietveld 408576698