chrome/browser/resources/settings/settings_ui/settings_ui.js - Issue 1700273003: MD Settings: make <paper-drawer-panel> flip in RTL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 1700273003: MD Settings: make <paper-drawer-panel> flip in RTL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_ui/settings_ui.js

diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js

index 513aa521d503b1b8eb1d6d095bc93ad26bd5c73a..70e256b76b792df719030355e429c79d155da1c6 100644

--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js

+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js

@@ -23,4 +23,17 @@ Polymer({

prefs: Object,

+ ready: function() {

+ assert(!document.documentElement.dir);

Dan Beam 2016/02/17 04:47:34 if this changes (i.e. dschuyler does <html dir="$i

+ this.listen(document, 'i18n-processed', 'onI18nProcessed_');

Dan Beam 2016/02/17 04:47:34 i can't use listeners because this doesn't bubble

michaelpg 2016/02/17 06:14:05 Why does this require waiting for this event at al

Dan Beam 2016/02/17 17:55:55 fixted it

+ },

+ /**

+ * @param {!Event} e

+ * @private

+ */

+ onI18nProcessed_: function(e) {

+ this.$.panel.rightDrawer = isRTL();

+ },

});