Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1700253002: Added ResourcePriorities field trial to the waterfall testing config in preparation for launch (Closed)

Created:
4 years, 10 months ago by Pat Meenan
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added ResourcePriorities field trial to the waterfall testing config in preparation for launch BUG=521744 Committed: https://crrev.com/64bc5ddf872133174294d6bbcd4536c06c8f6398 Cr-Commit-Position: refs/heads/master@{#375644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Pat Meenan
asvitkine@ PTAL. The experiment has been at 1% in stable since 47 (and at 10% ...
4 years, 10 months ago (2016-02-16 19:17:52 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 10 months ago (2016-02-16 19:21:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700253002/1
4 years, 10 months ago (2016-02-16 19:23:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 20:12:21 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/64bc5ddf872133174294d6bbcd4536c06c8f6398 Cr-Commit-Position: refs/heads/master@{#375644}
4 years, 10 months ago (2016-02-16 22:54:29 UTC) #8
Pat Meenan
4 years, 10 months ago (2016-02-17 16:16:38 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1707723002/ by pmeenan@chromium.org.

The reason for reverting is: Looks like the ResourcePriorities code is slowing
down the service workers micro benchmark pretty significantly (and
unexpectedly).  Disabling it until we can understand and fix why..

Powered by Google App Engine
This is Rietveld 408576698