Share const-error messages.

Share const-error messages.

R=brianwilkerson@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/830ac68d05273bec170f0d34203575a61f094b35

[floitsch, 2016-02-16 19:21:06]

floitsch@google.com changed reviewers:
+ brianwilkerson@google.com, johnniwinther@google.com

[Brian Wilkerson, 2016-02-17 15:01:21]

LGTM

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
File pkg/dart_messages/lib/shared_messages.dart (right):

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:297: " constructor.",
"constructor" --> "constructor(s)"

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:317: " constructor.",
Remove " or moving to the class' constructor"; it's unlikely to produce the
semantics that the user was attempting to accomplish.

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:358: template: "Members cannot be
declared to be both 'const' and 'final'",
"cannot" --> "can't" (for consistency)

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:359: howToFix: "Try removing the
'const' or 'final' keyword.",
"removing the" --> "removing either the"

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:376: template: "Members cannot be
declared to be both 'const' and 'var'",
"cannot" --> "can't"

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:377: howToFix: "Try removing the
'const' or 'var' keyword.",
"removing the" --> "removing either the"

[floitsch, 2016-02-17 15:26:44]

Thanks Brian.

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
File pkg/dart_messages/lib/shared_messages.dart (right):

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:297: " constructor.",
On 2016/02/17 15:01:21, Brian Wilkerson wrote:
> "constructor" --> "constructor(s)"

Done.

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:317: " constructor.",
On 2016/02/17 15:01:20, Brian Wilkerson wrote:
> Remove " or moving to the class' constructor"; it's unlikely to produce the
> semantics that the user was attempting to accomplish.

Done.

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:358: template: "Members cannot be
declared to be both 'const' and 'final'",
On 2016/02/17 15:01:20, Brian Wilkerson wrote:
> "cannot" --> "can't" (for consistency)

Done.

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:359: howToFix: "Try removing the
'const' or 'final' keyword.",
On 2016/02/17 15:01:21, Brian Wilkerson wrote:
> "removing the" --> "removing either the"

Done.

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:376: template: "Members cannot be
declared to be both 'const' and 'var'",
On 2016/02/17 15:01:21, Brian Wilkerson wrote:
> "cannot" --> "can't"

Done.

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:377: howToFix: "Try removing the
'const' or 'var' keyword.",
On 2016/02/17 15:01:21, Brian Wilkerson wrote:
> "removing the" --> "removing either the"

Done.

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:399: template: "Constructors cannot
have a return type",
fixed that one too.

https://codereview.chromium.org/1700243002/diff/20001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:400: howToFix: "Try removing the
return-type.",
changed to "return type".

[floitsch, 2016-02-17 17:08:30]

floitsch@google.com changed reviewers:
+ sigmund@google.com
- johnniwinther@google.com

[floitsch, 2016-02-17 17:08:30]

@Siggi: Johnni is on vacation. Could you review this CL for dart2js?

[Siggi Cherem (dart-lang), 2016-02-17 18:21:01]

lgtm

https://codereview.chromium.org/1700243002/diff/40001/pkg/compiler/lib/src/di...
File pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart (right):

https://codereview.chromium.org/1700243002/diff/40001/pkg/compiler/lib/src/di...
pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart:39: r'''
it might be nice to use a single line ' ' when the whole example is short and
1-line?

https://codereview.chromium.org/1700243002/diff/40001/pkg/dart_messages/lib/s...
File pkg/dart_messages/lib/shared_messages.dart (right):

https://codereview.chromium.org/1700243002/diff/40001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:101: /// The error sub-id of which
this message is a specialization.
by sub-id you mean that the id is the same for both?

Do we expect to have a hierarchy of specializations, or is it most commonly the
case that you have 1 generic and several children of it? (I mean, would
specializationOf practially always be 0?)

[floitsch, 2016-02-17 19:04:23]

https://codereview.chromium.org/1700243002/diff/40001/pkg/compiler/lib/src/di...
File pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart (right):

https://codereview.chromium.org/1700243002/diff/40001/pkg/compiler/lib/src/di...
pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart:39: r'''
On 2016/02/17 18:21:00, Siggi Cherem (dart-lang) wrote:
> it might be nice to use a single line ' ' when the whole example is short and
> 1-line?

Done.

https://codereview.chromium.org/1700243002/diff/40001/pkg/dart_messages/lib/s...
File pkg/dart_messages/lib/shared_messages.dart (right):

https://codereview.chromium.org/1700243002/diff/40001/pkg/dart_messages/lib/s...
pkg/dart_messages/lib/shared_messages.dart:101: /// The error sub-id of which
this message is a specialization.
On 2016/02/17 18:21:00, Siggi Cherem (dart-lang) wrote:
> by sub-id you mean that the id is the same for both?
> 
> Do we expect to have a hierarchy of specializations, or is it most commonly
the
> case that you have 1 generic and several children of it? (I mean, would
> specializationOf practially always be 0?)

I can imagine having different sub-ids here.
For example:
Generic id: "Unresolved".
dart2js sub-id: 0. "Class is unresolved"
dart2js sub-id: 1. "Property is unresolved"
analyzer sub-id: 2. "getter is unresolved" -> 1
analyzer sub-id: 3. "setter is unresolved" -> 1
analyzer sub-id: 4. "Super class is unresolved" -> 0
analyzer sub-id: 5. "Mixin class is unresolved" -> 0

It's hypothetical for now, and once all errors have been moved, we should
revisit the whole thing.

[floitsch, 2016-02-17 19:08:22]

Switched to double-quotes for the generated files, since we use double-quotes in
the shared_messages file.

[floitsch, 2016-02-17 19:10:34]

Description was changed from

==========
Share const-error messages.
==========

to

==========
Share const-error messages.

R=brianwilkerson@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/830ac68d05273bec170f0d34203575a61f094b35
==========

[floitsch, 2016-02-17 19:10:37]

Committed patchset #5 (id:80001) manually as
830ac68d05273bec170f0d34203575a61f094b35 (presubmit successful).