Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1700233002: Remove KeyboardEvent.prototype.keyLocation (alias of location) (Closed)

Created:
4 years, 10 months ago by philipj_slow
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove KeyboardEvent.prototype.keyLocation (alias of location) Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/lqknEaUYCJM/UbNahDDMAwAJ BUG=568261 Committed: https://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410 Cr-Commit-Position: refs/heads/master@{#375759}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700233002/1
4 years, 10 months ago (2016-02-16 19:06:49 UTC) #2
philipj_slow
PTAL
4 years, 10 months ago (2016-02-16 19:35:37 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 20:21:15 UTC) #6
tkent
lgtm https://codereview.chromium.org/1700233002/diff/1/third_party/WebKit/Source/core/testing/InternalDictionary.idl File third_party/WebKit/Source/core/testing/InternalDictionary.idl (right): https://codereview.chromium.org/1700233002/diff/1/third_party/WebKit/Source/core/testing/InternalDictionary.idl#newcode12 third_party/WebKit/Source/core/testing/InternalDictionary.idl:12: [DeprecateAs=PrefixedStorageInfo, ImplementedAs=longMember] long deprecateLongMember; ok, anything to be ...
4 years, 10 months ago (2016-02-16 23:33:54 UTC) #7
philipj_slow
https://codereview.chromium.org/1700233002/diff/1/third_party/WebKit/Source/core/testing/InternalDictionary.idl File third_party/WebKit/Source/core/testing/InternalDictionary.idl (right): https://codereview.chromium.org/1700233002/diff/1/third_party/WebKit/Source/core/testing/InternalDictionary.idl#newcode12 third_party/WebKit/Source/core/testing/InternalDictionary.idl:12: [DeprecateAs=PrefixedStorageInfo, ImplementedAs=longMember] long deprecateLongMember; On 2016/02/16 23:33:54, tkent wrote: ...
4 years, 10 months ago (2016-02-17 01:59:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700233002/1
4 years, 10 months ago (2016-02-17 02:00:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 02:13:56 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 02:15:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410
Cr-Commit-Position: refs/heads/master@{#375759}

Powered by Google App Engine
This is Rietveld 408576698