Issue 1700203002: Serialize and resynthesize unresolved identifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1700203002: Serialize and resynthesize unresolved identifiers. (Closed)

Created:
4 years, 10 months ago by scheglov

Modified:
4 years, 10 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Serialize and resynthesize unresolved identifiers. This is surprising, but SDK (dart2js part) has unresolved constant expressions. So, we need to support them at least to some extent in order to pass shared tests. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/665b82d04a7c9f6ef2bccc012c7de272de00cde8

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -18 lines)			Patch
M	pkg/analyzer/lib/src/summary/resynthesize.dart	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_elements.dart	View	2 chunks	+30 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View	3 chunks	+39 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/summary_common.dart	View	7 chunks	+79 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 10 months ago (2016-02-16 17:56:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
665b82d04a7c9f6ef2bccc012c7de272de00cde8 (presubmit successful).