Remove CFX_PtrList from renderer main loop.

Remove CFX_PtrList from renderer main loop.

Exposes an iterator over the object list, but not the object
holder, since pages and forms inherit from object holder, and
we don't want to imply that there's only one thing that might
be iterated over for those classes.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/2398d8938277a2492b411f8f807bf1935918ccae

[Tom Sepez, 2016-02-16 17:41:01]

Description was changed from

==========
Remove CFX_PtrList from renderer main loop.


BUG=
==========

to

==========
Remove CFX_PtrList from renderer main loop.

First, split CPDF_PageObjectList class into CPDF_PageObjectHolder
and CPDF_PageObjectList.  Expose an iterator over the object
list, but not the object holder, since pages and forms inherit
from object holder, and we don't want to imply that there's
only one thing that might be iterated over for those classes.

Then, remove the CFX_PtrList in favor of std::list.

BUG=
==========

[Tom Sepez, 2016-02-17 20:35:59]

Description was changed from

==========
Remove CFX_PtrList from renderer main loop.

First, split CPDF_PageObjectList class into CPDF_PageObjectHolder
and CPDF_PageObjectList.  Expose an iterator over the object
list, but not the object holder, since pages and forms inherit
from object holder, and we don't want to imply that there's
only one thing that might be iterated over for those classes.

Then, remove the CFX_PtrList in favor of std::list.

BUG=
==========

to

==========
Remove CFX_PtrList from renderer main loop.

Exposes an iterator over the object list, but not the object holder, since pages
and forms inherit
from object holder, and we don't want to imply that there's
only one thing that might be iterated over for those classes.
==========

[Tom Sepez, 2016-02-17 20:36:01]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-17 20:52:01]

Lei, pls review.

[Tom Sepez, 2016-02-17 20:53:24]

Description was changed from

==========
Remove CFX_PtrList from renderer main loop.

Exposes an iterator over the object list, but not the object holder, since pages
and forms inherit
from object holder, and we don't want to imply that there's
only one thing that might be iterated over for those classes.
==========

to

==========
Remove CFX_PtrList from renderer main loop.

Exposes an iterator over the object list, but not the object
holder, since pages and forms inherit from object holder, and
we don't want to imply that there's only one thing that might
be iterated over for those classes.
==========

[Lei Zhang, 2016-02-18 00:38:44]

lgtm

https://codereview.chromium.org/1700183002/diff/80001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_page.h (right):

https://codereview.chromium.org/1700183002/diff/80001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_page.h:151: CPDF_PageContentGenerator(CPDF_Page*
pPage);
explicit

https://codereview.chromium.org/1700183002/diff/80001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp (right):

https://codereview.chromium.org/1700183002/diff/80001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:1386: FX_FLOAT x_advance,
y_advance;
one per line

[Tom Sepez, 2016-02-18 00:46:33]

Description was changed from

==========
Remove CFX_PtrList from renderer main loop.

Exposes an iterator over the object list, but not the object
holder, since pages and forms inherit from object holder, and
we don't want to imply that there's only one thing that might
be iterated over for those classes.
==========

to

==========
Remove CFX_PtrList from renderer main loop.

Exposes an iterator over the object list, but not the object
holder, since pages and forms inherit from object holder, and
we don't want to imply that there's only one thing that might
be iterated over for those classes.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/2398d8938277a2492b411f8f807bf1935918...
==========

[Tom Sepez, 2016-02-18 00:46:34]

Committed patchset #6 (id:100001) manually as
2398d8938277a2492b411f8f807bf1935918ccae (presubmit successful).

[Tom Sepez, 2016-02-18 00:47:26]

https://codereview.chromium.org/1700183002/diff/80001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_page.h (right):

https://codereview.chromium.org/1700183002/diff/80001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_page.h:151: CPDF_PageContentGenerator(CPDF_Page*
pPage);
On 2016/02/18 00:38:44, Lei Zhang wrote:
> explicit

Done.

https://codereview.chromium.org/1700183002/diff/80001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp (right):

https://codereview.chromium.org/1700183002/diff/80001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:1386: FX_FLOAT x_advance,
y_advance;
On 2016/02/18 00:38:44, Lei Zhang wrote:
> one per line

Done.