Issue 170017: If you use the rebaseline.py script with a .git repo,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 170017: If you use the rebaseline.py script with a .git repo, (Closed)

Created:
11 years, 4 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Victor Wang

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

If you use the rebaseline.py script with a .git repo, it goes into an infinite loop. Instead, just skip the svn add step and keep going.

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	webkit/tools/layout_tests/rebaseline.py	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Victor Wang

11 years, 4 months ago (2009-08-14 23:07:24 UTC) #2

LGTM

Thanks for fixing the issue.

http://codereview.chromium.org/170017/diff/1/2
File webkit/tools/layout_tests/rebaseline.py (right):

http://codereview.chromium.org/170017/diff/1/2#newcode426
Line 426: logging.info("No svn checkout found.  Assuming it's a git repo and not
"
Remove the extra space before "Assuming".

Expand Messages | Collapse Messages