Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 170017: If you use the rebaseline.py script with a .git repo, (Closed)

Created:
11 years, 4 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Victor Wang
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

If you use the rebaseline.py script with a .git repo, it goes into an infinite loop. Instead, just skip the svn add step and keep going.

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webkit/tools/layout_tests/rebaseline.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
11 years, 4 months ago (2009-08-14 22:35:51 UTC) #1
Victor Wang
11 years, 4 months ago (2009-08-14 23:07:24 UTC) #2
LGTM

Thanks for fixing the issue.

http://codereview.chromium.org/170017/diff/1/2
File webkit/tools/layout_tests/rebaseline.py (right):

http://codereview.chromium.org/170017/diff/1/2#newcode426
Line 426: logging.info("No svn checkout found.  Assuming it's a git repo and not
"
Remove the extra space before "Assuming".

Powered by Google App Engine
This is Rietveld 408576698