Wrapperless dart:html and friends

tool/input_sdk/private/classes.dart

Index: tool/input_sdk/private/classes.dart
diff --git a/tool/input_sdk/private/classes.dart b/tool/input_sdk/private/classes.dart
index d10c6d727e233ae48a72dfff56db8d02f4046665..b06d949c83e32d5293668adaf95e7d82e8350dc9 100644
--- a/tool/input_sdk/private/classes.dart
+++ b/tool/input_sdk/private/classes.dart
@@ -186,6 +186,8 @@ _setStaticSignature(f, sigF) =>
 // Set the lazily computed runtime type field on static methods
 _setStaticTypes(f, names) => JS('', '''(() => {
   for (let name of $names) {
+    // TODO(vsm): Need to generate static methods.
+    if (!$f[name]) continue;
     $tagMemoized($f[name], function() {
       let parts = $f[$_staticSig][name];
       return $definiteFunctionType.apply(null, parts);
@@ -236,7 +238,7 @@ virtualField(subclass, fieldName) => JS('', '''(() => {
   let prop = $getOwnPropertyDescriptor($subclass.prototype, $fieldName);
   if (prop) return;
 
-  let symbol = Symbol($subclass.name + '.' + $fieldName);
+  let symbol = Symbol($subclass.name + '.' + $fieldName.toString());

[Jennifer Messerly, 2016/02/16 17:46:38]

nice fix! yeah this bug has existed for a while (private fields didn't work in
extension methods/virtual fields). This is the right fix.

The only thing maybe worth double checking is how it looks in debugger.

We could save the original string "_foobar" name on the Symbol, if it helps.

[Jacob, 2016/02/16 17:47:35]

nit: replace
$subclass.name + '.' + $fieldName.toString()

with
'${$subclass.name}.${$fieldName}'
and similar cleanup elsewhere in the file.

[vsm, 2016/02/18 01:13:09]

The double $ scares me.  :-)

   $defineProperty($subclass.prototype, $fieldName, {
     get: function() { return this[symbol]; },
     set: function(x) { this[symbol] = x; }
@@ -265,7 +267,7 @@ final dartx = JS('', '{}');
 
 getExtensionSymbol(name) => JS('', '''(() => {
   let sym = $dartx[$name];
-  if (!sym) $dartx[$name] = sym = Symbol('dartx.' + $name);
+  if (!sym) $dartx[$name] = sym = Symbol('dartx.' + $name.toString());
   return sym;
 })()''');
 
@@ -286,11 +288,13 @@ _installProperties(jsProto, extProto) => JS('', '''(() => {
 /// JavaScript class.
 ///
 registerExtension(jsType, dartExtType) => JS('', '''(() => {
+  // TODO(vsm): Not all registered js types are real.

[Jennifer Messerly, 2016/02/16 17:46:38]

yeah, it'd be really nice to avoid generating a call to this method if we can :)

[vsm, 2016/02/18 01:13:09]

Acknowledged.

+  if (!jsType) return;
+
   let extProto = $dartExtType.prototype;
   let jsProto = $jsType.prototype;
 
   // Mark the JS type's instances so we can easily check for extensions.
-  $assert_(jsProto[$_extensionType] === void 0);
   jsProto[$_extensionType] = $dartExtType;
   $_installProperties(jsProto, extProto);
   let originalSigFn = $getOwnPropertyDescriptor($dartExtType, $_methodSig).get;
@@ -321,6 +325,8 @@ defineExtensionMembers(type, methodNames) => JS('', '''(() => {
   let proto = $type.prototype;
   for (let name of $methodNames) {
     let method = $getOwnPropertyDescriptor(proto, name);
+    // TODO(vsm): Why?

[Jennifer Messerly, 2016/02/16 17:46:38]

yeah, this definitely needs further investigation. This looks like a compiler
bug, it asked us to generate "dartx.foo" for "foo", but it forgot to compile
"foo" in the first place. :)
 
What is "type" when this happens? I wonder if it's a native type? On native
types, it can be tricky to know where the method comes from, e.g.
HTMLElement/Element have gone through some refactoring over the last few years,
with methods moving "up" to Element so they can be shared by SVGElement.

That would suggest we could let ourself look up the proto chain. However, I
think we'd only want to do that for "native" types (not their subtypes).

[vsm, 2016/02/18 01:13:09]

Yes, a native type.  The type is dart:html WrappedEvent, but the method is
actually on Event.  Suggestions?

+    if (!method) continue;
     $defineProperty(proto, $getExtensionSymbol(name), method);
   }
   // Ensure the signature is available too.