Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: lib/runtime/dart/_debugger.js

Issue 1700153002: Wrapperless dart:html and friends (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/runtime/dart/_internal.js » ('j') | lib/src/codegen/js_codegen.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_debugger.js
diff --git a/lib/runtime/dart/_debugger.js b/lib/runtime/dart/_debugger.js
index 481253aa67fbf3cf4cbb435b92cd129d056bb06b..2923f06b0d480c4a0aca951cba56d2d5dc6e1814 100644
--- a/lib/runtime/dart/_debugger.js
+++ b/lib/runtime/dart/_debugger.js
@@ -384,13 +384,13 @@ dart_library.library('dart/_debugger', null, /* Imports */[
}
preview(object) {
let map = dart.as(object, core.Map);
- return `${getObjectTypeName(map)} length ${map.length}`;
+ return `${getObjectTypeName(map)} length ${map[dartx.length]}`;
}
children(object) {
let map = dart.as(object, core.Map);
- let keys = map.keys[dartx.toList]();
+ let keys = map[dartx.keys][dartx.toList]();
Jennifer Messerly 2016/02/16 17:46:38 how did Maps end up as a native type? I guess some
vsm 2016/02/18 01:13:09 Yes, I'm pretty sure we do.
let entries = dart.list([], NameValuePair);
- map.forEach(dart.fn((key, value) => {
+ map[dartx.forEach](dart.fn((key, value) => {
let entryWrapper = new MapEntry({key: dart.as(key, core.String), value: value});
entries[dartx.add](new NameValuePair({name: dart.toString(entries[dartx.length]), value: entryWrapper}));
}, dart.void, [dart.dynamic, dart.dynamic]));
« no previous file with comments | « no previous file | lib/runtime/dart/_internal.js » ('j') | lib/src/codegen/js_codegen.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698