Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tool/input_sdk/lib/html/html_common/conversions_dart2js.dart

Issue 1700153002: Wrapperless dart:html and friends (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tool/input_sdk/lib/html/html_common/conversions_dart2js.dart
diff --git a/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart b/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart
index aea9da0d136439903d04501a5c9c422cfd28765f..b7f3d7cbbccfd7604bb0b754bdbab6a95468147a 100644
--- a/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart
+++ b/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart
@@ -88,12 +88,12 @@ Future convertNativePromiseToDartFuture(promise) {
var completer = new Completer();
var then = convertDartClosureToJS((result) => completer.complete(result), 1);
var error = convertDartClosureToJS((result) => completer.completeError(result), 1);
- var newPromise = JS('', '#.then(#).catch(#)', promise, then, error);
+ var newPromise = JS('', '#.then(#)["catch"](#)', promise, then, error);
return completer.future;
}
/// Wrap a JS object with an instance of the matching dart:html class. Used only in Dartium.
-//wrap_jso(jsObject) => jsObject;
+wrap_jso(jsObject) => jsObject;
Jacob 2016/02/16 17:47:35 add a TODO that we shouldn't really be exposing th
vsm 2016/02/18 01:13:09 Done.
/// Find the underlying JS object for a dart:html Dart object.
-//unwrap_jso(dartClass_instance) => dartClass_instance;
+unwrap_jso(dartClass_instance) => dartClass_instance;

Powered by Google App Engine
This is Rietveld 408576698